Change in ovirt-engine[master]: webadmin: AbstractUserPortalListModel#finishSearch streams

Code Review gerrit at ovirt.org
Thu May 4 13:59:57 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: webadmin: AbstractUserPortalListModel#finishSearch streams
......................................................................


webadmin: AbstractUserPortalListModel#finishSearch streams

Use Java 8's stream to clean up the implementation of finishSearch
and replace the boilerplate for-loop that was used there.

Note that the original implementation had an unwanted(?) side-effect
of sorting the vmOrPoolAndPoolRepresentants passed to it which was
never noticed as it was always called with local variables that were
immediately disposed afterwards. This cleanup also removes that side
effect.

Change-Id: I7628853600dfb35407be0a51edef029065aaeeac
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/AbstractUserPortalListModel.java
1 file changed, 4 insertions(+), 10 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/76442
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7628853600dfb35407be0a51edef029065aaeeac
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list