Change in ovirt-engine[master]: core: Avoid injection in StorageDomainHelper

Code Review gerrit at ovirt.org
Thu May 4 15:05:23 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: Avoid injection in StorageDomainHelper
......................................................................


core: Avoid injection in StorageDomainHelper

Since all of the data to be logged is already present at the creating of
the audit-log entity, there is no need to inject any beans to the
AuditLogableBase and it can be replaced with a leaner and more efficient
implementation of the AuditLogable.

Change-Id: I833a18e9c24e4e0d03a90367b378509e70b2a46f
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StorageDomainHelper.java
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Tal Nisan: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests
  Freddy Rolland: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/76379
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I833a18e9c24e4e0d03a90367b378509e70b2a46f
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list