Change in ovirt-engine[master]: engine: Avoid injection in GetVmsFromExternalProviderQuery

Code Review gerrit at ovirt.org
Sun May 7 11:19:41 UTC 2017


>From Moti Asayag <masayag at redhat.com>:

Moti Asayag has submitted this change and it was merged.

Change subject: engine: Avoid injection in GetVmsFromExternalProviderQuery
......................................................................


engine: Avoid injection in GetVmsFromExternalProviderQuery

Since all of the data to be logged is already present at the creating of
the audit-log entity, there is no need to inject any beans to the
AuditLogableBase and it can be replaced with a leaner and more efficient
implementation of the AuditLogable.

Change-Id: Ie0ee416b3eb339b90e5cb76662241928fadc2cf2
Signed-off-by: Moti Asayag <masayag at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsFromExternalProviderQuery.java
1 file changed, 15 insertions(+), 10 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Arik Hadas: Looks good to me, approved
  Moti Asayag: Verified



-- 
To view, visit https://gerrit.ovirt.org/76255
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0ee416b3eb339b90e5cb76662241928fadc2cf2
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list