Change in ovirt-engine[master]: engine: Avoid injection in VdsNotRespondingTreatmentCommand
Code Review
gerrit at ovirt.org
Sun May 7 15:55:25 UTC 2017
>From Moti Asayag <masayag at redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Avoid injection in VdsNotRespondingTreatmentCommand
......................................................................
engine: Avoid injection in VdsNotRespondingTreatmentCommand
Since all of the data to be logged is already present at the creating of
the audit-log entity, there is no need to inject any beans to the
AuditLogableBase and it can be replaced with a leaner and more efficient
implementation of the AuditLogable.
Change-Id: I739e7bc4d544477d8f90c7b1c9d9f1e95f59a6d9
Signed-off-by: Moti Asayag <masayag at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/VdsNotRespondingTreatmentCommand.java
1 file changed, 15 insertions(+), 9 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Moti Asayag: Verified
--
To view, visit https://gerrit.ovirt.org/76276
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I739e7bc4d544477d8f90c7b1c9d9f1e95f59a6d9
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list