Change in ovirt-engine[master]: engine: Use AuditLogDirector directly

Code Review gerrit at ovirt.org
Sun May 7 15:58:55 UTC 2017


>From Moti Asayag <masayag at redhat.com>:

Moti Asayag has submitted this change and it was merged.

Change subject: engine: Use AuditLogDirector directly
......................................................................


engine: Use AuditLogDirector directly

The AlertDirecor is a naive wrapper of AuditLogDirector, however, it
doesn't add any value on top of a direct call to AuditLogDirector.

The AlertDirector makes a false assumption that the 'alert' severity is
determined by its logging, however, that is controlled by the severity
of the audit log type.

Therefore, all logging should be done directly by the AuditLogDirector.

Change-Id: Ie2c7cde3822b6fa4b5bf1b7a5c994ef106eeb2ae
Signed-off-by: Moti Asayag <masayag at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/PmHealthCheckManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AlertDirector.java
4 files changed, 22 insertions(+), 36 deletions(-)

Approvals:
  Denis Chaplygin: Looks good to me, but someone else must approve
  Martin Sivák: Looks good to me, but someone else must approve
  Eli Mesika: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Roy Golan: Looks good to me, approved
  Moti Asayag: Verified



-- 
To view, visit https://gerrit.ovirt.org/76450
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2c7cde3822b6fa4b5bf1b7a5c994ef106eeb2ae
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir at redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list