Change in ovirt-engine[master]: core: NPE in addStep method of Step

Code Review gerrit at ovirt.org
Mon May 8 13:44:52 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: NPE in addStep method of Step
......................................................................


core: NPE in addStep method of Step

In some cases when running from compensation, task creation fails
with NPE on addStep method of Step.

In this patch when loading steps in JobRepositoryImpl, the steps list is not
set if the list is null.

Change-Id: Icd895174bfc48ca1087d53328cffa2b0b6191fca
Bug-Url: https://bugzilla.redhat.com/1415691
Signed-off-by: Fred Rolland <frolland at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryImpl.java
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Ravi Nori: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved
  Freddy Rolland: Verified



-- 
To view, visit https://gerrit.ovirt.org/76551
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icd895174bfc48ca1087d53328cffa2b0b6191fca
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list