Change in ovirt-engine[master]: async-command: Remove setting parent command

Code Review gerrit at ovirt.org
Mon May 8 14:05:31 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: async-command: Remove setting parent command
......................................................................


async-command: Remove setting parent command

If setting the RunAsyncActionCommand as the parent of the command being
executed (original command), the original command "endAction" method
isn't invoked, leaving it not completed.
This change is valid for commands that could be run asynchronously.

Change-Id: Iae4abd65206e4422f1758d8a258c8d36d265f192
Bug-Url: https://bugzilla.redhat.com/1447050
Signed-off-by: Ala Hino <ahino at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunAsyncActionCommand.java
1 file changed, 2 insertions(+), 8 deletions(-)

Approvals:
  Ravi Nori: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved
  Freddy Rolland: Looks good to me, but someone else must approve
  Ala Hino: Verified
  Liron Aravot: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/76249
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iae4abd65206e4422f1758d8a258c8d36d265f192
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list