Change in ovirt-engine[master]: engine: remove UpdateClusterNetworkClusterValidator

Code Review gerrit at ovirt.org
Tue May 9 08:38:45 UTC 2017


>From Alona Kaplan <alkaplan at redhat.com>:

Alona Kaplan has submitted this change and it was merged.

Change subject: engine: remove UpdateClusterNetworkClusterValidator
......................................................................


engine: remove UpdateClusterNetworkClusterValidator

The change enables adding a detached cluster to a DC
Prior the change adding a detached non-empty cluster to a DC, failed
with "changing the management network in a non-empty cluster" message.

On the other hand after adding a detached cluster with hosts to a DC,
the actual network that the engine communicates with the hosts in this
cluster might be different from the declared management network.

Change-Id: I7525fbf7cc7838192df131321bf1935823e3004d
Signed-off-by: Yevgeny Zaspitsky <yzaspits at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/UpdateClusterNetworkClusterValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateClusterCommandTest.java
D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/UpdateClusterNetworkClusterValidatorTest.java
4 files changed, 5 insertions(+), 100 deletions(-)

Approvals:
  Alona Kaplan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Yevgeny Zaspitsky: Verified



-- 
To view, visit https://gerrit.ovirt.org/75710
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7525fbf7cc7838192df131321bf1935823e3004d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list