Change in ovirt-engine[master]: engine: reuse ClusterOperationCommandBase.validateManagement...

Code Review gerrit at ovirt.org
Tue May 9 18:38:27 UTC 2017


>From Alona Kaplan <alkaplan at redhat.com>:

Alona Kaplan has submitted this change and it was merged.

Change subject: engine: reuse ClusterOperationCommandBase.validateManagementNetwork
......................................................................


engine: reuse ClusterOperationCommandBase.validateManagementNetwork

The patch pulls up common parts of validateManagementNetwork method
from (Add|UpdateClusterCommand) classes to the common base class.

Change-Id: Id98499865164b489fbabe9d3b91eb838d4d920a1
Signed-off-by: Yevgeny Zaspitsky <yzaspits at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddClusterCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClusterOperationCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java
3 files changed, 65 insertions(+), 75 deletions(-)

Approvals:
  Alona Kaplan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Yevgeny Zaspitsky: Verified



-- 
To view, visit https://gerrit.ovirt.org/76546
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id98499865164b489fbabe9d3b91eb838d4d920a1
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list