Change in ovirt-engine[ovirt-engine-4.1]: core: TransferDiskImage validation - get storage domain id f...

Code Review gerrit at ovirt.org
Wed May 10 14:16:58 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: TransferDiskImage validation - get storage domain id from disk
......................................................................


core: TransferDiskImage validation - get storage domain id from disk

TransferDiskImageCommand -> validateImageTransfer:
The StorageDomainValidator should be created using the disk's
storage domain id, as the new disk is already created.
Currently, the domain id is fetched from command's parameters,
which is available only when uplaoding from the WebAdmin.

Change-Id: I801f71079e031367cf87b527ae2bf5c3bf1623e7
Bug-Url: https://bugzilla.redhat.com/1447023
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommandTest.java
2 files changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Daniel Erez: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/76651
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I801f71079e031367cf87b527ae2bf5c3bf1623e7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list