Change in ovirt-engine[master]: core: Remove explicit nulls from fixtures.xml

Code Review gerrit at ovirt.org
Thu May 11 13:05:56 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: Remove explicit nulls from fixtures.xml
......................................................................


core: Remove explicit nulls from fixtures.xml

Explicitly stating null column values in DBUnit's flat XML is usually
redundant at best (assuming the column doesn't have a non-null
default) or confusing at worst (as it's unclear whether
mycolumn="null" means the column should get a null value or the
string literal 'null').

This patch cleans up the fixtures file by removing these nulls.

Change-Id: Ifd9258c67483312f47bd66dc33f48ae4a1c47e46
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/dal/src/test/resources/fixtures.xml
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/76680
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd9258c67483312f47bd66dc33f48ae4a1c47e46
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list