Change in ovirt-engine[ovirt-engine-4.1]: webadmin, userportal: Ensure table column vertical separator
Code Review
gerrit at ovirt.org
Fri May 12 07:37:35 UTC 2017
>From Piotr Kliczewski <piotr.kliczewski at gmail.com>:
Piotr Kliczewski has submitted this change and it was merged.
Change subject: webadmin,userportal: Ensure table column vertical separator
......................................................................
webadmin,userportal: Ensure table column vertical separator
1, move `border-right` & `margin-right` from ResizableHeader.css
into TabCellTable.css (base style for most table widgets)
2, remove redundancy in PopupCellTable.css (same styles already
declared in TabCellTable.css)
3, cleanup px-based values, e.g. `padding: 0 3px` instead of the
unnecessary verbose `padding: 0px 3px`
Change-Id: I9d26b95254619767a88a83b86489f488f87b76dd
Bug-Url: https://bugzilla.redhat.com/1403847
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/PopupCellTable.css
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/ResizableHeader.css
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/TabCellTable.css
3 files changed, 8 insertions(+), 27 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
Vojtech Szocs: Verified
--
To view, visit https://gerrit.ovirt.org/76682
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9d26b95254619767a88a83b86489f488f87b76dd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list