Change in ovirt-engine[master]: core: Avoid NPE when creating an instance type

[Code Review]

>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged.

Change subject: core: Avoid NPE when creating an instance type
......................................................................


core: Avoid NPE when creating an instance type

Several changes were made in AddVmTemplateCommand

* Avoid NPE in checkTrustedService() when creating an instance type;
* Avoid NPE in getJobMessageProperties();
* Do not take lock on empty VM ID when creating an instance type.

Change-Id: Ifa2b4e555b5050e15979affba5a9935c8e28ac04
Bug-Url: https://bugzilla.redhat.com/1450000
Signed-off-by: Shmuel Melamud <smelamud at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
1 file changed, 12 insertions(+), 4 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Shmuel Leib Melamud: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/76857
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa2b4e555b5050e15979affba5a9935c8e28ac04
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>