Change in ovirt-engine[master]: packaging: Introduce absolute path to FIREWALLD_SERVICES
Code Review
gerrit at ovirt.org
Wed May 17 07:45:15 UTC 2017
>From Sandro Bonazzola <sbonazzo at redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: Introduce absolute path to FIREWALLD_SERVICES
......................................................................
packaging: Introduce absolute path to FIREWALLD_SERVICES
Being able to specify firewalld services outside of
OVIRT_FIREWALLD_CONFIG will make integration with external
providers easier.
Change-Id: I34d51b571f2f34355153666cbe7124a458f56a58
Signed-off-by: Leon Goldberg <lgoldber at redhat.com>
---
M packaging/setup/plugins/ovirt-engine-common/base/network/process_firewalld_services.py
1 file changed, 22 insertions(+), 6 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Marcin Mirecki: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Leon Goldberg: Verified
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/76861
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I34d51b571f2f34355153666cbe7124a458f56a58
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber at redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde at redhat.com>
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael at rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list