Change in ovirt-engine[master]: core: Detach/Remove SD - allowed domain status

[Code Review]

>From Liron Aravot <laravot at redhat.com>:

Liron Aravot has submitted this change and it was merged.

Change subject: core: Detach/Remove SD - allowed domain status
......................................................................


core: Detach/Remove SD - allowed domain status

This patch prevents detaching/removing a SD while the domain status
isn't Maintenance.
The PreparingForMaintenance status was added in order to make sure
that when a domain moves to Maintenance status it's not accessed by any host
in the data center.

Currently we allow to detach/remove(a local sd) when the domain status
is Inactive, while on that status it still may be accessed by some of the hosts.
This patch changes that and allows to detach/remove a SD only when its on
Maintenance status - an Inactive domain must be deactivated prior to being detached.

Change-Id: I4c18dee175c457aa7aed5ee5bfc8b9803c1aba9d
Bug-Url: https://bugzilla.redhat.com/1418020
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBaseTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/VdcActionUtilsTest.java
4 files changed, 10 insertions(+), 3 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved
  Liron Aravot: Verified



-- 
To view, visit https://gerrit.ovirt.org/71398
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4c18dee175c457aa7aed5ee5bfc8b9803c1aba9d
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>