Change in ovirt-engine[master]: core: RemoveStoragePool - allowed domain statuses

Code Review gerrit at ovirt.org
Wed May 17 12:47:38 UTC 2017


>From Liron Aravot <laravot at redhat.com>:

Liron Aravot has submitted this change and it was merged.

Change subject: core: RemoveStoragePool - allowed domain statuses
......................................................................


core: RemoveStoragePool - allowed domain statuses

This patch prevents removing a DC while there's a domain which
isn't on Maintenance status.

Currently we allow to remove a DC when there's a domain in Inactive status,
while it still may be accessed by some of the hosts.
This patch changes that and allows to remove a DC only when its domains are on
Maintenance status - an Inactive domains must be deactivated prior to removing the DC.

Change-Id: I784ad9758de867b5092f06761ba9f0880fd6436d
Bug-Url: https://bugzilla.redhat.com/1418020
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RemoveStoragePoolCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/RemoveStoragePoolCommandTest.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 29 insertions(+), 23 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved
  Liron Aravot: Verified



-- 
To view, visit https://gerrit.ovirt.org/71399
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I784ad9758de867b5092f06761ba9f0880fd6436d
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list