Change in ovirt-engine[master]: restapi: Mocking VdcReturnValueBase
Code Review
gerrit at ovirt.org
Mon May 22 10:43:45 UTC 2017
>From Allon Mureinik <amureini at redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: restapi: Mocking VdcReturnValueBase
......................................................................
restapi: Mocking VdcReturnValueBase
VdcReturnValueBase is a POJO with no interesting logic defined in the
common module.
As such, there's very little benefit in mocking it instead of just
returning a new instance in the test.
Besides cleaning up the code, this patch mainly lays some ground work
towards making VdcReturnValueBase final.
Change-Id: I7da59e00a683ebd828d776d19870ccafa8cf9588
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResourceTest.java
2 files changed, 15 insertions(+), 17 deletions(-)
Approvals:
Ori Liel: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
Vojtech Szocs: Looks good to me, but someone else must approve
Moti Asayag: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/76961
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7da59e00a683ebd828d776d19870ccafa8cf9588
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Ori Liel <oliel at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list