Change in ovirt-log-collector[master]: produceReport: Extract DWS SQL query from shell script to .sql

Code Review gerrit at ovirt.org
Mon May 22 14:33:47 UTC 2017


>From Douglas Schilling Landgraf <dougsland at redhat.com>:

Douglas Schilling Landgraf has submitted this change and it was merged.

Change subject: produceReport: Extract DWS SQL query from shell script to .sql
......................................................................


produceReport: Extract DWS SQL query from shell script to .sql

For portabilitiy let's keep the .sql out from the shell script
when possible.

Change-Id: Ia22e25092e7145c042e3fd4220c37dcd0737057f
Signed-off-by: Douglas Schilling Landgraf <dougsland at redhat.com>
---
M src/inventory_report/Makefile.am
M src/inventory_report/produceReport/produceReport.sh
A src/inventory_report/produceReport/sqls/dws_query_check_if_its_running.sql
3 files changed, 20 insertions(+), 7 deletions(-)

Approvals:
  Douglas Schilling Landgraf: Verified; Looks good to me, approved
  Sandro Bonazzola: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/77047
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia22e25092e7145c042e3fd4220c37dcd0737057f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list