Change in ovirt-hosted-engine-setup[master]: engineapi: avoid hardcoding admin at internal

Code Review gerrit at ovirt.org
Tue May 23 05:41:51 UTC 2017


>From Sandro Bonazzola <sbonazzo at redhat.com>:

Sandro Bonazzola has submitted this change and it was merged.

Change subject: engineapi: avoid hardcoding admin at internal
......................................................................


engineapi: avoid hardcoding admin at internal

Avoid hardcoding admin at internal since the user
could disable the internal admin user for
security reason and so the authentication
could fail.

Change-Id: I4f6bcbed749435547f20d7b57d129774dfbee45b
Bug-Url: https://bugzilla.redhat.com/1439281
Signed-off-by: Simone Tiraboschi <stirabos at redhat.com>
---
M src/ovirt_hosted_engine_setup/constants.py
M src/ovirt_hosted_engine_setup/engineapi.py
M src/plugins/gr-he-common/engine/ca.py
3 files changed, 19 insertions(+), 1 deletion(-)

Approvals:
  Sandro Bonazzola: Looks good to me, approved
  Simone Tiraboschi: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/76168
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4f6bcbed749435547f20d7b57d129774dfbee45b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>


More information about the Engine-commits mailing list