Change in ovirt-engine[master]: findbugs: Fix warning in CreateAllTemplateDisksFromSnapshotC...

Code Review gerrit at ovirt.org
Tue May 23 12:58:05 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: findbugs: Fix warning in CreateAllTemplateDisksFromSnapshotCommand
......................................................................


findbugs: Fix warning in CreateAllTemplateDisksFromSnapshotCommand

The fields vmHandler masks a field with the same name in the superclass
causing findbugs to issue a MF_CLASS_MASKS_FIELD warning, this patch
removes the injection in the class and use the same injected member of
the superclass which is the same

Change-Id: Id364877d0d152c900740efc53af30933415bdc63
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/CreateAllTemplateDisksFromSnapshotCommand.java
1 file changed, 0 insertions(+), 6 deletions(-)

Approvals:
  Tal Nisan: Verified
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/77169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id364877d0d152c900740efc53af30933415bdc63
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list