Change in ovirt-engine[master]: build-tools: Escape ' when calling AbstractCheck#log

Code Review gerrit at ovirt.org
Wed May 24 14:28:49 UTC 2017


>From Vojtech Szocs <vszocs at redhat.com>:

Vojtech Szocs has submitted this change and it was merged.

Change subject: build-tools: Escape ' when calling AbstractCheck#log
......................................................................


build-tools: Escape ' when calling AbstractCheck#log

Looks like the ' character is used for escaping:

  log(i, "shouldn't") -> "shouldnt"
  log(i, "shouldn''t") -> "shouldn't"

Change-Id: Ifc1bd82f0eb82abc1b9886c8aa4686fba4b3d91d
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M build-tools-root/ovirt-checkstyle-extension/src/main/java/org/ovirt/checkstyle/checks/NlsCheck.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved
  Greg Sheremeta: Looks good to me, approved
  Vojtech Szocs: Verified



-- 
To view, visit https://gerrit.ovirt.org/77042
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc1bd82f0eb82abc1b9886c8aa4686fba4b3d91d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Scott Dickerson <sdickers at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list