Change in ovirt-engine[master]: search: fix tags/values with underscore behaviour
Code Review
gerrit at ovirt.org
Thu May 25 14:26:00 UTC 2017
>From Martin Peřina <mperina at redhat.com>:
Martin Peřina has submitted this change and it was merged.
Change subject: search: fix tags/values with underscore behaviour
......................................................................
search: fix tags/values with underscore behaviour
This patch fixes a regression caused by [1] that attempts to resolve [2]
The fix caused tags including an "_" attached to Host or VM not to work.
The problem was that the [1] patch put "\" before "_" not only for a
condition with LIKE/ILIKE but also for "=" condition which cause the
search to return empty results.
The problem is that we have generated queries with ILIKE/LIKE in two forms :
1) <field> LIKE/ILIKE <value>
2) <value> LIKE/ILIKE ANY (string_to_array ......
[1] https://gerrit.ovirt.org/#/c/69926
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1409849
Change-Id: I3d8e2075f99ce2600e64bd996280c68feb8f3fa0
Bug-Url : https://bugzilla.redhat.com/show_bug.cgi?id=1446525
Signed-off-by: emesika <emesika at redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VdcUserConditionFieldAutoCompleter.java
3 files changed, 4 insertions(+), 5 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Eli Mesika: Verified
Ravi Nori: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77204
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3d8e2075f99ce2600e64bd996280c68feb8f3fa0
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list