[Engine-devel] find-bugs errors - please investigate/fix

[Tal Nisan]

Seems that the cleanup worked, now the actual results after the frontend 
cleanup pathces are shown without the false positives
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4069/

On 04/24/2013 10:11 AM, Michal Skrivanek wrote:
> On Apr 24, 2013, at 07:49 , Sahina Bose<sabose at redhat.com>  wrote:
>
>> On 04/24/2013 07:47 AM, Einav Cohen wrote:
>>> ovirt find-bugs errors in jenkins - please investigate/fix asap.
>>> [@Eyal - FYI: some of them seem really strange - see Michal's section below]
>>>
>>> @Sahina Bose:
>>> find-bugs error details:
>>> http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.-267688716/source.349621/#23
>>> caused by: http://gerrit.ovirt.org/#/c/13831/
>> Have submitted a patch (http://gerrit.ovirt.org/#/c/14187/) fixing this. Thanks!
>>> @Michael Kublin:
>>> find-bugs error details:
>>> http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.-609324659/source.347305/#346
>>> caused by:
>>> http://gerrit.ovirt.org/#/c/13740/
>>>
>>> @Michal Skrivanek:
>>>
>>> the following seem strange - can you please investigate? could be false positives.
>>>
>>> - find-bugs error details:
>>> http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-2082646592/source.350390/#1349
>>> [not sure when introduced - seems old, hence I suspect it is a false positive]
>>>
>>> - Two additional errors in the same file as ^^^, you can see them at:
>>> http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-2082646592/
>>> when clicking on them, there aren't any details, however according to their tool-tips, it seems to be an "unreachable
>>> OnSuccess method within an anonymous class" or something similar.
>>>
>>> - another suspicious error is in VmListModel.java:
>>> http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-1516395789/source.350485/#2406
>>> [again - not sure when introduced - seems old, hence I suspect it is a false positive]
> Doesn't really seem to work correctly. Tooltip is talking about OnSuccess method for all mine above and it really doesn't seem to correspond with reality.
> Looks like findbugs is broken or confused
>
>>> ----
>>> Thanks,
>>> Einav
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel