[Engine-devel] UiCommon models in UserPortal - note about optimization logic

[Vojtech Szocs]

Hi,

recently we faced an issue [1] where UserPortal UI refresh optimization logic [2] interfered with direct UiCommon model updates.

The optimization logic compares freshly received data with existing data and doesn't trigger UI refresh when there's no change. This inherently implies that UiCommon SearchableListModel shouldn't manipulate its item data directly, or it risks the situation when the optimization logic thinks there's no change (data retrieved from server matches updated item data).

(Possible improvement: add "dirty" flag to item model type (UserPortalItemModel) that would be called when UiCommon SearchableListModel does direct item manipulation.)

Vojtech

[1] http://gerrit.ovirt.org/#/c/14148/
[2] AbstractUserPortalListProvider.updateDataProvider method override