[Engine-devel] Share Your Thoughts

[Roy Golan]

On Sun 23 Mar 2014 04:13:41 PM IST, Itamar Heim wrote:
> On 03/23/2014 04:01 PM, Gilad Chaplik wrote:
>>
>>
>> Thanks,
>> Gilad.
>>
>> ----- Original Message -----
>>> From: "Omer Frenkel" <ofrenkel at redhat.com>
>>> To: "Eli Mesika" <emesika at redhat.com>
>>> Cc: "Gilad Chaplik" <gchaplik at redhat.com>, "engine-devel"
>>> <engine-devel at ovirt.org>
>>> Sent: Sunday, March 23, 2014 3:35:28 PM
>>> Subject: Re: [Engine-devel] Share Your Thoughts
>>>
>>>
>>>
>>> ----- Original Message -----
>>>> From: "Eli Mesika" <emesika at redhat.com>
>>>> To: "Gilad Chaplik" <gchaplik at redhat.com>
>>>> Cc: "engine-devel" <engine-devel at ovirt.org>
>>>> Sent: Sunday, March 23, 2014 2:41:15 PM
>>>> Subject: Re: [Engine-devel] Share Your Thoughts
>>>>
>>>>
>>>>
>>>> ----- Original Message -----
>>>>> From: "Eli Mesika" <emesika at redhat.com>
>>>>> To: "Gilad Chaplik" <gchaplik at redhat.com>
>>>>> Cc: "engine-devel" <engine-devel at ovirt.org>
>>>>> Sent: Sunday, March 23, 2014 2:36:17 PM
>>>>> Subject: Re: [Engine-devel] Share Your Thoughts
>>>>>
>>>>>
>>>>>
>>>>> ----- Original Message -----
>>>>>> From: "Gilad Chaplik" <gchaplik at redhat.com>
>>>>>> To: "engine-devel" <engine-devel at ovirt.org>
>>>>>> Sent: Sunday, March 23, 2014 2:06:01 PM
>>>>>> Subject: [Engine-devel] Share Your Thoughts
>>>>>>
>>>>>> Dear Devel Community Members,
>>>>>>
>>>>>> We are having a small discussion on patch:
>>>>>> http://gerrit.ovirt.org/#/c/25633/,
>>>>>> bug 1065753 - "Maintenance operations on a VM would ask for an
>>>>>> optional
>>>>>> reason" (adding a note to stop/shutdown VM, that will be cleared
>>>>>> when
>>>>>> the
>>>>>> VM
>>>>>> go up).
>>>>>>
>>>>>> The proposed solution is to add a free text field in the VM
>>>>>> entity, and
>>>>>> to
>>>>>> update it in command's parameters (StopVmParmas.. etc.).
>>>>>>
>>>>>> I think slightly different, my alternative is to enhance the current
>>>>>> free
>>>>>> text (comment field) into XML, and allow to add multiple comments
>>>>>> that
>>>>>> include types.
>>>>>> You are welcome to read more about it in the patch's comments.
>>>>>>
>>>>>> Thoughts?
>>>>>
>>>>> I suggest a third approach
>>>>> We are logging here a reason for a user/admin operation
>>>>> The natural place for such information is the audit log and not
>>>>> the VM
>>>>> tables.
>>>>> I think that the audit log messages related for the stop/shutdown
>>>>> commands
>>>>> should be enhanced to include a {REASON} field then the command
>>>>> itself
>>>>> will
>>>>> replace this value in the message with the one given by the user
>>>>> and we
>>>>> are
>>>>> done.
>>>>> Again, the required information is a pure logging issue, therefor I
>>>>> suggest
>>>>> to put this information in the correct place for it, there is no
>>>>> point in
>>>>> saving any logging messages in any entity table.
>>>>>
>>>>> Technically:
>>>>> 1) The option for giving a reason should be configurable (per
>>>>> Cluster if
>>>>> I
>>>>> look at Arthur comment in the BZ)
>>>>> 2) If the option is on than any stop/shutdown will ask for reason and
>>>>> sent
>>>>> it
>>>>> in the command parameters
>>>> than=>then
>>>>> 3) If the command succeed and got a non-empty reason , it will set
>>>>> the
>>>>> reason
>>>>> in the command audit log message
>>>>>
>>>>
>>>> 4) We gain here additional advantage since we can :
>>>>     a) search for the reason using the search engine
>>>>     b) get the reason in the message text sent to us if we are
>>>> subscribed
>>>>     for
>>>>     the VM stop/shotdown event ans using engine-notifier
>>>>
>>>>>
>>>>> Eli
>>>>>
>>>
>>> +1
>>> sounds like a good and simple idea
>>

+1 another reason is we should keep Vm dynamic as compact as possible. 
using dynamic to hold a shutdown reason is an abuse.

>> +1, BUT this is completely a different feature, and more difficult
>> (MUCH more, if I may add).
>> IMHO we need both, lets start with the no-brainer.
>
> AuditLog gets recycled after 30 days. the reason i stopped my VM may
> still be relevant.
> I would not make fields complex/composite. they need to be easily
> useable via the CLI for example.
>


>>
>>>
>>>>>>
>>>>>> Thanks,
>>>>>> Gilad.
>>>>>> _______________________________________________
>>>>>> Engine-devel mailing list
>>>>>> Engine-devel at ovirt.org
>>>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>>>>
>>>>>
>>>> _______________________________________________
>>>> Engine-devel mailing list
>>>> Engine-devel at ovirt.org
>>>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>>>
>>>
>> _______________________________________________
>> Engine-devel mailing list
>> Engine-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/engine-devel
>>
>
> _______________________________________________
> Engine-devel mailing list
> Engine-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel