[Engine-devel] Share Your Thoughts

[Gilad Chaplik]

----- Original Message -----
> From: "Adam Litke" <alitke at redhat.com>
> To: "Gilad Chaplik" <gchaplik at redhat.com>
> Cc: "engine-devel" <engine-devel at ovirt.org>
> Sent: Monday, March 24, 2014 3:00:20 PM
> Subject: Re: [Engine-devel] Share Your Thoughts
> 
> On 24/03/14 08:43 -0400, Adam Litke wrote:
> >On 23/03/14 10:36 -0400, Gilad Chaplik wrote:
> >>>AuditLog gets recycled after 30 days. the reason i stopped my VM may
> >>>still be relevant.
> >>>I would not make fields complex/composite. they need to be easily
> >>>useable via the CLI for example.
> >>
> >>I think we need multiple comments, so we need to think about the RESTful
> >>api anyhow.
> >>I guess that next feature will be a reason for 'wipe after stop'/any other
> >>BE that needs reasoning.
> >
> >What about a new DB table (maybe called Annotations) that takes a
> >business entity type, UUID, action type, timestamp, and reason string.
> >Then the shutdown reason could be entered as a new row in the DB.  It
> >can be kept as long as we want it and views can be adjusted to make
> >these fields searchable.
> 
> I forgot to mention that this idea would make it simple to annotate
> the reason for moving a host into maintenance mode as well (or any
> other state change annotations we would want to make in the future).
> 

Hi Adam,

Sorry for not being clear enough, the change of the comment free-text field should be an infra one, 
and can be applied for all other comment fields, we will start with VM because it's required for now, and reuse the same code for other entities when needed.
I've discusses with Eli off-line and he came up with the same idea as yours (great minds think alike ;) - it's not just in advertising).
Personally, I think it's an overhead for now, there no problem adding it later, and it's quite simple actually.

3 comments:
* I think Eli's solution is nice to have but not complete. gave +1 because I thought it's a bigger feature that what he wants (a simple write to log), because in order to meet the RFE/bug 's requirements with logging, we need to pin the audit log into the entity itself (flag the entity according to audit log), IMHO logging isn't good enough UX-wise.
* Regarding Itamar's comment:
   1) Is this field is a tech preview? if not, we can still support strings in that field as well.
   2) Saving XML will allow us to get the RESTful API out of the box (just need to format it according to requested user's presentation).
   3) We can add the types as part of the API.
   4) Did someone say custom properties sheet in REST? :-)
* Regarding the cluster level config (requested in the bug, and implemented in the patch), if we are going on it, we need a separate thread on it (and I'm -1 on it, btw), a simple checkbox 'do not show this textbox/message again' in browser's local-data will do the trick.

Thanks, 
Gilad.

> --
> Adam Litke
>