Email notification for unit-test build failure

[Eyal Edri]

The build now shows better view on junit tests.
and an UNSTABLE result:

channel stopped
[xUnit] [INFO] - Starting to record.
[xUnit] [INFO] - Processing JUnit
[xUnit] [INFO] - [JUnit] - 235 test report file(s) were found with the pattern '**/target/surefire-reports/*.xml' relative to '/var/lib/jenkins/workspace/ovirt_engine_unit_tests' for the testing framework 'JUnit'.
[xUnit] [INFO] - Check 'Failed Tests' threshold.
[xUnit] [INFO] - The total number of tests for this category exceeds the specified 'unstable' threshold value.
[xUnit] [INFO] - Setting the build status to UNSTABLE
[xUnit] [INFO] - Stopping recording.
Email was triggered for: Unstable
Sending email for trigger: Unstable
Sending email to: eedri at redhat.com engine-patches at ovirt.org rgolan at redhat.com vszocs at redhat.com
Finished: UNSTABLE


----- Original Message -----
> From: "Jon Choate" <jchoate at redhat.com>
> To: "Eyal Edri" <eedri at redhat.com>
> Cc: infra at ovirt.org
> Sent: Monday, February 13, 2012 5:43:53 PM
> Subject: Re: Email notification for unit-test build failure
> 
> On 02/13/2012 10:31 AM, Eyal Edri wrote:
> >
> > ----- Original Message -----
> >> From: "Jon Choate"<jchoate at redhat.com>
> >> To: infra at ovirt.org
> >> Sent: Monday, February 13, 2012 5:19:10 PM
> >> Subject: Re: Email notification for unit-test build failure
> >>
> >> On 02/13/2012 10:16 AM, Eyal Edri wrote:
> >>> The build is unstable due to those errors:
> >>>
> >>> http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/136/
> >>>
> >>> the flag 'send to commiters' was not set, that's why no email was
> >>> sent. (fixed now).
> >>>
> >>> Eyal.
> >> I think the real concern is that the maven build does not fail
> >> even
> >> if
> >> there are errors in some of the tests.  It actually says "Build
> >> Successful". This in turn results in a yellow ball in Jenkins.  I
> >> think
> > It shouldn't be this way, the build should finish with 'UNSTABLE'
> > status.
> > i will look into it and see how to fix this.
> >
> >> it should be red since the tests are not working.
> > i disagree.
> > we use yellow 'unstable' for jobs that have failed tests in rhevm
> > jenkins for all of our jobs.
> > a job that has a RED indicator (failed), should mean it was a major
> > failure, usually environment related or if it has a large number
> > of tests failing.
> 
> Ok.  I view any failing tests as a major failure but its really a
> matter
> of opinion.  I can always pretend that when I see yellow I am seeing
> red!
> 
> Thanks for looking in to this.
> 
> >
> >
> >>> ----- Original Message -----
> >>>> From: "Moti Asayag"<masayag at redhat.com>
> >>>> To: infra at ovirt.org, "Eyal Edri"<eedri at redhat.com>
> >>>> Sent: Monday, February 13, 2012 5:04:15 PM
> >>>> Subject: Email notification for unit-test build failure
> >>>>
> >>>> Hi,
> >>>>
> >>>> I've noticed when unit tests failed, Jenkins does not fail the
> >>>> build
> >>>> and
> >>>> send no emails about the failure: no email was sent to
> >>>> engine-patches.
> >>>>
> >>>> See under the bll unit-test:
> >>>> http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/136/consoleFull
> >>>>
> >>>> 08:33:22,411 INFO  [Version] Hibernate Validator 4.0.2.GA
> >>>> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> >>>> 3.051
> >>>> sec<<<   FAILURE!
> >>>> ...
> >>>> [ERROR] There are test failures.
> >>>>
> >>>> However the build ended successfully:
> >>>> ------------------------------------------------------------------------
> >>>> [INFO] BUILD SUCCESSFUL
> >>>> ------------------------------------------------------------------------
> >>>> channel stopped
> >>>> No emails were triggered.
> >>>> Finished: SUCCESS
> >>>>
> >>>> Could you verify no flag for ignore-failed-tests were set ?
> >>>>
> >>>> Thanks,
> >>>> Moti
> >>>>
> >>> _______________________________________________
> >>> Infra mailing list
> >>> Infra at ovirt.org
> >>> http://lists.ovirt.org/mailman/listinfo/infra
> >> _______________________________________________
> >> Infra mailing list
> >> Infra at ovirt.org
> >> http://lists.ovirt.org/mailman/listinfo/infra
> >>
> 
>