Gerrit's gitweb page is missing public git url

[Mike Burns]

On Mon, 2012-07-09 at 22:25 +0300, Itamar Heim wrote:
> On 07/09/2012 10:13 PM, Mike Burns wrote:
> > On Mon, 2012-07-09 at 22:07 +0300, Itamar Heim wrote:
> >> On 07/09/2012 01:44 PM, Mike Burns wrote:
> >>> On Mon, 2012-07-09 at 07:55 +0300, Itamar Heim wrote:
> >>>> On 07/06/2012 09:00 PM, Mike Burns wrote:
> >>>>> On Fri, 2012-07-06 at 18:10 +0300, Itamar Heim wrote:
> >>>>>> On 07/05/2012 02:48 PM, Fabian Deutsch wrote:
> >>>>>>> Hey,
> >>>>>>>
> >>>>>>> I just noted that the public gerrit gitweb page is missing the public
> >>>>>>> git url to a repo.
> >>>>>>>
> >>>>>>> E.g.: ovirt-node-tests
> >>>>>>> Gitweb page: http://gerrit.ovirt.org/gitweb?p=ovirt-node-tests.git
> >>>>>>>
> >>>>>>> Names http and private git url:
> >>>>>>> http://gerrit.ovirt.org/p/ovirt-node-tests.git
> >>>>>>> ssh://.../ovirt-node-tests.git
> >>>>>>>
> >>>>>>> Public git url (git://gerrit.ovirt.org/ovirt-node-tests) is missing.
> >>>>>>> It would be nice if this url could also be displayed, as git transport
> >>>>>>> is faster than http.
> >>>>>>>
> >>>>>>
> >>>>>> its the same for all projects, not just ovirt-node-tests.
> >>>>>> find me how to configure it and i will...
> >>>>>
> >>>>> In the gitweb.conf (or the equivalent), set:
> >>>>> our @git_base_url_list = qw(git://gerrit.ovirt.org
> >>>>>                                ssh://gerrit.ovirt.org);
> >>>>
> >>>> I wish it was that easy...
> >>>> gerrit passes its own (for example, you will get the ssh link from
> >>>> gitweb if you are logged in to gerrit, etc.).
> >>>> and it manipulates git_base_url_list accordingly.
> >>>>
> >>>> http://code.google.com/p/gerrit/source/browse/gerrit-httpd/src/main/java/com/google/gerrit/httpd/gitweb/GitWebServlet.java
> >>>
> >>> Ahh, ok, I have my gitweb config independent of gerrit.  Looks like you
> >>> need GIT_ANONYMOUS_READ set and a git daemon url set.  Looking at [1], i
> >>> think you need download.scheme=anon_git and
> >>> gerrit.canonicalGitUrl=git://gerrit.ovirt.org set in etc/gerrit.conf.
> >>
> >> wouldn't changing canonicalGitUrl will cause the default one to stop
> >> being web based for links?
> >> today we have this as the default:
> >> canonicalWebUrl = http://gerrit.ovirt.org
> >
> > Should be 2 separate entries.
> >
> > canonicalWebUrl=http://...
> > canonicalGitUrl=git://...
> 
> indeed.
> done - check it out...

Looks good to me.  ;-)
> _______________________________________________
> Infra mailing list
> Infra at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra