[Infra] Jenkins: Possible wrong configuration of the job vdsm_unit_tests_manual_gerrit

[Zhou Zheng Sheng]

Hi,

This job is for running unit test on new patches submit to
gerrit.ovirt.org. I found every time this job runs, it just checkout the
origin/master of vdsm, but not the submitted patch.

For example,
In

http://gerrit.ovirt.org/#/c/9315/

the commit hash of patch set 2 is 0fca07f9526c, but in the related build

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/71/console

The log says it

Checking out Revision a7b2577107c5b30b4078ead37717d2176693143d (origin/master)

And you can see the same problem in

http://gerrit.ovirt.org/#/c/9346/

and

http://gerrit.ovirt.org/#/c/9345/

These two are different patches, but the related build at
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/80/console
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/79/console
all do the same checkout as said in the log.

Checking out Revision 2c0fd0796ad6ac7132340016198d30519c71bc8f (origin/master)

Since commit 2c0fd079 of the current origin master contains a bug, it
can not pass the build process so the above two patches get a verify
failure comment by Jenkins. What's worse, if the current master is good
and some patches got bugs, Jenkins will not find out those bug and
happily give +1 as verify comment.

Could you check the job configuration? Maybe you can examine the
advanced settings of the git repository configuration and check if
Refspec is $GERRIT_REFSPEC, Branch Specifier is $GERRIT_BRANCH, and
examine the gerrit trigger to check if branch pattern is **. These
settings works for me, I hope it can help you a little bit.

-- 
Thanks and best regards!

Zhou Zheng Sheng / 周征晟
E-mail: zhshzhou at linux.vnet.ibm.com
Telephone: 86-10-82454397