[Engine-devel] checkstyle and tools project

[Laszlo Hornyak]

Hi Eyal,

Without the patch checkstyle will fail, there are some violations.
But Yair ACKed the patchset, I will rebase and check it over again and merge, should be ready ~today~.


----- Original Message -----
> From: "Eyal Edri" <eedri at redhat.com>
> To: "Laszlo Hornyak" <lhornyak at redhat.com>
> Cc: "engine-devel" <engine-devel at ovirt.org>, "infra" <infra at ovirt.org>
> Sent: Monday, June 24, 2013 4:28:44 PM
> Subject: Re: [Engine-devel] checkstyle and tools project
> 
> Can we add a gerrit hook to run checkstyle on the code?
> rather than waiting it to be merged and fail on jenkins?
> 
> ----- Original Message -----
> > From: "Laszlo Hornyak" <lhornyak at redhat.com>
> > To: "engine-devel" <engine-devel at ovirt.org>
> > Sent: Monday, June 24, 2013 11:15:38 AM
> > Subject: [Engine-devel] checkstyle and tools project
> > 
> > Hi,
> > 
> > Checkstyle is not executed on tools project. I have sent a patch to gerrit
> > to
> > fix this, could you guys review?
> > 
> > http://gerrit.ovirt.org/15719
> > 
> > And there are some more cleanup patches for tools:
> > http://gerrit.ovirt.org/15720
> > http://gerrit.ovirt.org/15721
> > http://gerrit.ovirt.org/15722
> > 
> > 
> > Thank you,
> > Laszlo
> > _______________________________________________
> > Engine-devel mailing list
> > Engine-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/engine-devel
> > 
>