Engine Upgrade job

[Eyal Edri]

go for it.

----- Original Message -----
> From: "Kiril Nesenko" <kiril at redhat.com>
> To: "Alex Lourie" <alourie at redhat.com>, "Eyal Edri" <eedri at redhat.com>
> Cc: "Ohad Basan" <obasan at redhat.com>, "Sandro Bonazzola" <sbonazzo at redhat.com>, "infra" <infra at ovirt.org>
> Sent: Wednesday, May 8, 2013 2:35:16 PM
> Subject: Re: Engine Upgrade job
> 
> 
> 
> ----- Original Message -----
> > From: "Alex Lourie" <alourie at redhat.com>
> > To: "Ohad Basan" <obasan at redhat.com>
> > Cc: "Sandro Bonazzola" <sbonazzo at redhat.com>, "Kiril Nesenko"
> > <kiril at redhat.com>, "infra" <infra at ovirt.org>
> > Sent: Wednesday, May 8, 2013 12:37:06 AM
> > Subject: Re: Engine Upgrade job
> > 
> > 
> > 
> > On Tue, May 7, 2013 at 10:53 PM, Ohad Basan <obasan at redhat.com> wrote:
> > > 
> > > 
> > > ----- Original Message -----
> > >>  From: "Kiril Nesenko" <kiril at redhat.com>
> > >>  To: "Alex Lourie" <alourie at redhat.com>, "Sandro Bonazzola"
> > >> <sbonazzo at redhat.com>
> > >>  Cc: "infra" <infra at ovirt.org>
> > >>  Sent: Tuesday, May 7, 2013 10:33:33 PM
> > >>  Subject: Engine Upgrade job
> > >>  
> > >>  Hello,
> > >>  I am working on engine upgrade job. I have a slave with
> > >> 'ip-10-82-253-208'
> > >>  hostname.
> > >>  This job fails on engine-setup [1] because of this hostname.
> > >> Sandro, Alex can
> > >>  you take a look please ?
> > >> 
> > > this is due to the following code:
> > > 
> > >     if not validateDomain(param,options):
> > >         return False
> > > 
> > > in engine-validators.py
> > > we can patch this out just for the upgrade job or change the regex
> > > that is being used.
> > > 
> > 
> > The failing job is actually the correct behavior. The provided FQDN
> > parameter failed validation (as Ohad said).
> > 
> > You can choose to ignore the validator by commenting out the code, but
> > you'll have to do it in every job and for each test for each patch.
> > 
> > The other way would be providing a real fqdn in answer file, which is
> > much better solution.
> 
> Thanks Alex. Eyal, can we change the hostname of this slave to a real one ?
> > 
> > > 
> > > 
> > >>  
> > >>  [1]
> > >>  
> > >> http://jenkins.ovirt.org/job/ovirt_engine_upgrade_stable_32_to_latest_32/lastSuccessfulBuild/artifact/engine-setup_2013_05_02_10_55_46.log
> > >>  
> > >>  - Kiril
> > >>  _______________________________________________
> > >>  Infra mailing list
> > >>  Infra at ovirt.org
> > >>  http://lists.ovirt.org/mailman/listinfo/infra
> > >>  
> > >> 
> > 
> > _______________________________________________
> > Infra mailing list
> > Infra at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> > 
>