findbugs errors -- any way to prevent mad bot from rampant -1s?

[Allon Mureinik]

----- Original Message -----
> From: "Greg Sheremeta" <gshereme at redhat.com>
> To: infra at ovirt.org, devel at ovirt.org
> Cc: "Eyal Edri" <eedri at redhat.com>
> Sent: Tuesday, December 9, 2014 1:52:01 AM
> Subject: findbugs errors -- any way to prevent mad bot from rampant -1s?
> 
> Hi,
> 
> Is there any way to prevent this [1] from happening?
> 
> Some patch got merged that findbugs complains about. Basically no
> patches can be merged until that is fixed and everybody rebases
> everything (because the bot -1's everything). That doesn't seem right.

What really doesn't seem is that:
a. a maintainer merged a patch that doesn't pass findbugs.
b. it's been a couple of days and this hasn't been fixed yet.

Having said that, I posted a fix[1] for the last issue, pending front-end maintainers' review

[1] http://gerrit.ovirt.org/#/c/36002/

> 
> [1] http://i.imgur.com/NNHx1bq.png
> 
> --
> Greg Sheremeta
> Red Hat, Inc.
> Sr. Software Engineer, RHEV
> Cell: 919-807-1086
> gshereme at redhat.com
> _______________________________________________
> Infra mailing list
> Infra at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra
>