gerrit requiring signed-off-by?

[Fabian Deutsch]

Am Mittwoch, den 29.01.2014, 22:00 +0200 schrieb Itamar Heim:
> On 01/28/2014 10:05 PM, David Caro wrote:
> > El mar 28 ene 2014 18:12:14 CET, Fabian Deutsch escribió:
> >> Hey,
> >>
> >> is it new that gerrit requires commits to have the SIgned-Off-By string
> >> in the commit msg?
> >>
> >> Thanks
> >> fabian
> >>
> >>
> >> _______________________________________________
> >> Infra mailing list
> >> Infra at ovirt.org
> >> http://lists.ovirt.org/mailman/listinfo/infra
> >
> > Which project are you referring to?
> >
> > As far as I remember most of the projects required it and some did not.
> > I don't remember changing it though, so the projects that did not
> > require it should haven't started requiring them. Tell me the project
> > you are referring too and I'll take a look.
> 
> I'm pretty sure all projects required that since day 1.

Yes.

It was my missunderstanding.

The gerrit rule checks is not just chekcing the presence of the line but
also that this line matches either the submitter or the author.
The patch I was looking at, had a Signed-Off-By line which differed from
the author.

- fabian

> 
> >
> > --
> > David Caro
> >
> > Red Hat S.L.
> > Continuous Integration Engineer - EMEA ENG Virtualization R&D
> >
> > Email: dcaro at redhat.com
> > Web: www.redhat.com
> > RHT Global #: 82-62605
> >
> >
> >
> > _______________________________________________
> > Infra mailing list
> > Infra at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> >
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ovirt.org/pipermail/infra/attachments/20140205/4d93be91/attachment.sig>