gerrit bot bug

[Greg Sheremeta]

Yep. But it indeed looks to us like, when a score is already 0 and you rebase,
'-Verified' gets applied (again!) and the total score is then -1.

So I vote bug. Not sure if it's out bot or gerrit.

----- Original Message -----
> From: "Einav Cohen" <ecohen at redhat.com>
> To: "Greg Sheremeta" <gshereme at redhat.com>
> Cc: "David Caro" <dcaroest at redhat.com>, "Eyal Edri" <eedri at redhat.com>, infra at ovirt.org, "Alexander Wels"
> <awels at redhat.com>
> Sent: Thursday, March 19, 2015 4:59:55 PM
> Subject: Re: gerrit bot bug
> 
> > ----- Original Message -----
> > From: "Greg Sheremeta" <gshereme at redhat.com>
> > Sent: Thursday, March 19, 2015 4:47:35 PM
> > 
> > Looks like it's happening when we rebase a patch that the bot has already
> > seen.
> > 
> > """
> > oVirt Jenkins CI Server has posted comments on this change.
> > 
> > Change subject: webadmin: display contents of comments instead of icon
> > ......................................................................
> > 
> > Patch Set 14: -Verified
> > 
> > Build Started (1/3) ->
> > http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/46062/
> > """
> > 
> > Is '-Verified' moving it from no score to -1?
> 
> AFAIK, '-Verified' resets the score (i.e. sets score to '0') and 'Verified-1'
> sets the score to '-1' (see attached);
> '-Verified' is not supposed to set the score to '-1'; if it does - it may be
> a bug.
> 
> > 
> > 
> > 
> > ----- Original Message -----
> > > From: "Greg Sheremeta" <gshereme at redhat.com>
> > > To: "David Caro" <dcaroest at redhat.com>, "Eyal Edri" <eedri at redhat.com>,
> > > infra at ovirt.org
> > > Cc: "Einav Cohen" <ecohen at redhat.com>
> > > Sent: Thursday, March 19, 2015 9:24:53 AM
> > > Subject: gerrit bot bug
> > > 
> > > Hi guys,
> > > 
> > > I believe we're experiencing a gerrit bot bug on patch [1]. See this
> > > screenshot [2].
> > > 
> > > Patchset 5 built cleanly, and tried to remove Verified-1, but it
> > > couldn't.
> > > "Patch Set 5: -Code-Review -Verified  Build Successful"
> > > but yet
> > > "Verified -1 oVirt Jenkins CI Server"
> > > 
> > > We're stuck not being able to merge this patch.
> > > 
> > > I'll fire a manual build to see if a second good build removes it.
> > > But this looks like a bug to me.
> > > 
> > > [1] https://gerrit.ovirt.org/#/c/38739/
> > > [2] http://i.imgur.com/uesa9SC.png
> > > 
> > > Greg Sheremeta
> > > Red Hat, Inc.
> > > Sr. Software Engineer, RHEV
> > > Cell: 919-807-1086
> > > gshereme at redhat.com
> > > 
> > 
>