[TICKET] This patch breaks the upgrade (no it doesn't!)

[Eyal Edri]

----- Original Message -----
> From: "Greg Sheremeta" <gshereme at redhat.com>
> To: "infra" <infra at ovirt.org>
> Cc: "Tal Nisan" <tnisan at redhat.com>, "Alexander Wels" <awels at redhat.com>
> Sent: Tuesday, May 26, 2015 7:28:28 PM
> Subject: [TICKET] This patch breaks the upgrade (no it doesn't!)
> 
> """
> Jenkins CI
> May 25 5:42 AM
> Patch Set 3:
> Build Unstable
> http://jenkins.ovirt.org/job/ovirt-engine_3.5_upgrade-from-3.4_merged/1488/ :
> This patch breaks the upgrade, fix asap please
> """
> 
> Our patch did not affect the upgrade. We ignored and merged the patch.

actually this is a real issue that was only fixed yesterday [1],
since the error was in for some time, any patch running on it will fail,
as it the patch is rebased on HEAD.

in normal flow the patch that caused this error wouldn't have been merged at all,
or at least reverted immediately.

this is a good example why its so important to check failing jobs and not ignore them
when they happen, as it will block all future patches like it happened to your patch.

to make sure, i moved the job to slient mode, so it won't bother you or give -1,
once we'll see its stable enough we'll re-enable it.



[1] 
Commit 0e87ed2877f56d12da4dea4387ad67f56bbc45e4 by Yedidyah Bar David
packaging: setup: pki: Enroll certs on upgrade if not exist
reports key/cert were generated by 3.5 clean setup, but not by upgrade
(and did not exist in <=3.4). This didn't cause a failure because they 
are not used by default. Generate on upgrade.
Bug-Url: https://bugzilla.redhat.com/1224656 Change-Id:
I9ed93d47a55f2971337bac277ce69c672901bb07 Signed-off-by: Yedidyah Bar
David <didi at redhat.com>
(cherry picked from commit de16430f6609586a5530f3db579c36be1b12815e)

> 
> https://gerrit.ovirt.org/#/c/41360/
> 
> Greg Sheremeta
> Red Hat, Inc.
> Sr. Software Engineer, RHEV
> Cell: 919-807-1086
> gshereme at redhat.com
> _______________________________________________
> Infra mailing list
> Infra at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra
> 
> 
>