Add AssertJ to artifactory

[Alon Bar-Lev]

----- Original Message -----
> From: "Roy Golan" <rgolan at redhat.com>
> To: "Alon Bar-Lev" <alonbl at redhat.com>
> Cc: "Eyal Edri" <eedri at redhat.com>, "Roman Mohr" <rmohr at redhat.com>, "infra" <infra at ovirt.org>
> Sent: Wednesday, September 2, 2015 5:37:35 PM
> Subject: Re: Add AssertJ to artifactory
> 
> On Wed, Sep 2, 2015 at 5:33 PM, Alon Bar-Lev <alonbl at redhat.com> wrote:
> 
> >
> >
> > ----- Original Message -----
> > > From: "Roy Golan" <rgolan at redhat.com>
> > > To: "Alon Bar-Lev" <alonbl at redhat.com>
> > > Cc: "Eyal Edri" <eedri at redhat.com>, "Roman Mohr" <rmohr at redhat.com>,
> > "infra" <infra at ovirt.org>
> > > Sent: Wednesday, September 2, 2015 5:25:18 PM
> > > Subject: Re: Add AssertJ to artifactory
> > >
> > > On Wed, Sep 2, 2015 at 4:56 PM, Alon Bar-Lev <alonbl at redhat.com> wrote:
> > >
> > > > needless to say that this assertj is not available in fedora and if not
> > > > actually required for production use and actual important use case
> > should
> > > > not be added as dependency to our project.
> > > >
> > >
> > > What the issue with jars for test?
> >
> > when building rpm tests run, right?
> >
> >
> Let me put it more simple,
> Whats the "risk" in adding any test jar into the compilation stage? it
> doesn't get shipped and doesn't change the binaries
> 

it does not allow us to build with fedora when all components are built from sources as fedora packaging requires.
this is violation of what we target, hence should not be used, even if it is nice to have or comfortable.
we had these discussions in the past, no need to repeat them.
a dependency should be added only when it is actually plays important role in our production or building production, not because any other reason, these dependencies that absent in fedora should  be avoided unless there is a major virtualization feature that it is required for.

> 
> 
> 
> > >
> > >
> > > >
> > > > ----- Original Message -----
> > > > > From: "Roy Golan" <rgolan at redhat.com>
> > > > > To: "Eyal Edri" <eedri at redhat.com>
> > > > > Cc: "Roman Mohr" <rmohr at redhat.com>, "infra" <infra at ovirt.org>
> > > > > Sent: Wednesday, September 2, 2015 4:52:20 PM
> > > > > Subject: Re: Add AssertJ to artifactory
> > > > >
> > > > > Thanks, its there.
> > > > >
> > > > > On Wed, Sep 2, 2015 at 3:40 PM, Eyal Edri < eedri at redhat.com >
> > wrote:
> > > > >
> > > > >
> > > > >
> > > > > you're looking at the wrong artifactory.
> > > > > our mirror in in
> > http://artifactory.ovirt.org/artifactory/ovirt-mirror .
> > > > >
> > > > > e.
> > > > >
> > > > > On Wed, Sep 2, 2015 at 1:42 PM, Roy Golan < rgolan at redhat.com >
> > wrote:
> > > > >
> > > > >
> > > > >
> > > > > I would expect the artifactory to find it on a search query but it
> > didn't
> > > > >
> > > >
> > http://artifactory.eng.lab.tlv.redhat.com:8081/artifactory/webapp/search/artifact/?3&q=assertj
> > > > >
> > > > > On Wed, Sep 2, 2015 at 1:37 PM, Eyal Edri < eedri at redhat.com >
> > wrote:
> > > > >
> > > > >
> > > > >
> > > > > adding infra.
> > > > > any reason why this isn't on maven central?
> > > > >
> > > > > e.
> > > > >
> > > > > On Wed, Sep 2, 2015 at 12:35 PM, Roy Golan < rgolan at redhat.com >
> > wrote:
> > > > >
> > > > >
> > > > >
> > > > > We want to add a test jar dependency to the project and want to make
> > sure
> > > > > artifactory has that.
> > > > >
> > > > > Can you add this?
> > > > >
> > > > > http://mvnrepository.com/artifact/org.assertj/assertj-core/2.1.0
> > > > >
> > > > >
> > > > > <dependency>
> > > > > <groupId>org.assertj</groupId>
> > > > > <artifactId>assertj-core</artifactId>
> > > > > <version>2.1.0</version>
> > > > > </dependency>
> > > > >
> > > > >
> > > > > Thanks
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Eyal Edri
> > > > > Supervisor, RHEV CI
> > > > > EMEA ENG Virtualization R&D
> > > > > Red Hat Israel
> > > > >
> > > > > phone: +972-9-7692018
> > > > > irc: eedri (on #tlv #rhev-dev #rhev-integ)
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Eyal Edri
> > > > > Supervisor, RHEV CI
> > > > > EMEA ENG Virtualization R&D
> > > > > Red Hat Israel
> > > > >
> > > > > phone: +972-9-7692018
> > > > > irc: eedri (on #tlv #rhev-dev #rhev-integ)
> > > > >
> > > > >
> > > > > _______________________________________________
> > > > > Infra mailing list
> > > > > Infra at ovirt.org
> > > > > http://lists.ovirt.org/mailman/listinfo/infra
> > > > >
> > > >
> > >
> >
>