[JIRA] (OVIRT-624) another invalid CI-1

[Juan Hernández]

On 07/08/2016 10:12 AM, Eyal Edri wrote:
> So I'm not sure its a false positive, it was real issue at that time and
> a rebase was needed to fix it.
> What we do need to investigate is why juan's patch wasn't given -1
> before merge, juan - can you check what did the findbugs job say on your
> patch?
> 

This is the patch that introduced the issue:

  restapi: Always populate V3 disk interface and bootable
  https://gerrit.ovirt.org/59731

This patch triggered the build jobs and the findbugs job. The findbugs
job finised at 11:28, and voted CI-1. The build jobs finished a bit
later, at 11:32, and voted CI+1. The net result was CI+1. Maybe we
should change the logic here so that a successful job in a specific
patch set can't override a negative vote from an earlier failed job.

> On Fri, Jul 8, 2016 at 11:08 AM, Juan Hernández <jhernand at redhat.com
> <mailto:jhernand at redhat.com>> wrote:
> 
>     On 07/08/2016 09:29 AM, Eyal Edri wrote:
>     > I marked this build as keep forever so we can debug it.
>     > Also, we are in the process of moving to a new findbugs jobs which are
>     > written in Yaml and have a few small fixes,
>     > so i've disabled the old job in favor
>     > of http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_created_test/.
>     >
>     > @snaftaly from my team is working on it and will be able to debug it
>     > next week.
>     >
>     > My suspicison is that your patch was rebased at some point on another
>     > patch with this failure which came from patch [1].
>     > Juan - did you see at any point findbugs error on your patch and fixed it?
>     >
>     > [1] https://gerrit.ovirt.org/#/c/59828/
>     >
> 
>     Eyal, that findbugs failure was introduced by a patch of mine, and then
>     it was resolved by patch [1]. Patch [1] is already merged, but Martin's
>     patch isn't rebased on top of it.
> 
>     Martin, rebase your patch and the issue will disappear.
> 
>     > On Thu, Jul 7, 2016 at 10:22 PM, Martin Mucha (oVirt JIRA)
>     > <jira at ovirt-jira.atlassian.net
>     <mailto:jira at ovirt-jira.atlassian.net>
>     <mailto:jira at ovirt-jira.atlassian.net
>     <mailto:jira at ovirt-jira.atlassian.net>>>
>     > wrote:
>     >
>     >     Martin Mucha created OVIRT-624:
>     >     ----------------------------------
>     >
>     >                  Summary: another invalid CI-1
>     >                      Key: OVIRT-624
>     >                      URL: https://ovirt-jira.atlassian.net/browse/OVIRT-624
>     >                  Project: oVirt - virtualization made easy
>     >               Issue Type: By-EMAIL
>     >                 Reporter: Martin Mucha
>     >                 Assignee: infra
>     >
>     >
>     >     Hi,
>     >
>     >     this build gave invalid ci -1:
>     >     http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/46153/
>     >
>     >     findbugs complaint about class not altered in patch.
>     >
>     >     please react quickly, before build disappears.
>     >     Thanks,
>     >     M.
>     >
>     >
>     >
>     >     --
>     >     This message was sent by Atlassian JIRA
>     >     (v1000.133.0#100004)
>     >     _______________________________________________
>     >     Infra mailing list
>     >     Infra at ovirt.org <mailto:Infra at ovirt.org>
>     <mailto:Infra at ovirt.org <mailto:Infra at ovirt.org>>
>     >     http://lists.ovirt.org/mailman/listinfo/infra
>     >
>     >
>     >
>     >
>     >
>     > --
>     > Eyal Edri
>     > Associate Manager
>     > RHEV DevOps
>     > EMEA ENG Virtualization R&D
>     > Red Hat Israel
>     >
>     > phone: +972-9-7692018 <tel:%2B972-9-7692018>
>     > irc: eedri (on #tlv #rhev-dev #rhev-integ)
>     >
>     >
>     > _______________________________________________
>     > Infra mailing list
>     > Infra at ovirt.org <mailto:Infra at ovirt.org>
>     > http://lists.ovirt.org/mailman/listinfo/infra
>     >
> 
> 
>     --
>     Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta
>     3ºD, 28016 Madrid, Spain
>     Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat
>     S.L.
> 
> 
> 
> 
> -- 
> Eyal Edri
> Associate Manager
> RHEV DevOps
> EMEA ENG Virtualization R&D
> Red Hat Israel
> 
> phone: +972-9-7692018
> irc: eedri (on #tlv #rhev-dev #rhev-integ)
> 
> 
> _______________________________________________
> Infra mailing list
> Infra at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra
> 


-- 
Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta
3ºD, 28016 Madrid, Spain
Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.