2 bugs in test setup

[Nir Soffer]

Hi all,

I noticed 2 bugs in the code setting up a test:

1. losetup is run with non-existent -D option
2. build does not fail although losetup failed

In the current state, test may run with loop devices left from another
test - this
used to cause random failures for vdsm tests.

See log bellow.

Nir

----

22:46:04 Triggered by Gerrit: https://gerrit.ovirt.org/60064
22:46:04 Building remotely on el6-vm08.phx.ovirt.org (el6 vm phx
nested) in workspace
/home/jenkins/workspace/ovirt-imageio_master_check-patch-fc23-x86_64
22:46:04 Cloning the remote Git repository
22:46:04 Cloning repository git://gerrit.ovirt.org/ovirt-imageio.git
22:46:04  > git init
/home/jenkins/workspace/ovirt-imageio_master_check-patch-fc23-x86_64/ovirt-imageio
# timeout=10
22:46:04 Fetching upstream changes from git://gerrit.ovirt.org/ovirt-imageio.git
22:46:04  > git --version # timeout=10
22:46:04  > git fetch --tags --progress
git://gerrit.ovirt.org/ovirt-imageio.git
+refs/heads/*:refs/remotes/origin/*
22:46:06  > git config remote.origin.url
git://gerrit.ovirt.org/ovirt-imageio.git # timeout=10
22:46:06  > git config --add remote.origin.fetch
+refs/heads/*:refs/remotes/origin/* # timeout=10
22:46:06  > git config remote.origin.url
git://gerrit.ovirt.org/ovirt-imageio.git # timeout=10
22:46:06 Cleaning workspace
22:46:06  > git rev-parse --verify HEAD # timeout=10
22:46:06 No valid HEAD. Skipping the resetting
22:46:06  > git clean -fdx # timeout=10
22:46:06 Pruning obsolete local branches
22:46:06 Fetching upstream changes from git://gerrit.ovirt.org/ovirt-imageio.git
22:46:06  > git fetch --tags --progress
git://gerrit.ovirt.org/ovirt-imageio.git refs/changes/64/60064/1
--prune
22:46:06  > git rev-parse
19ce0a36c76c3d95658fecd8f59077fc9641e24c^{commit} # timeout=10
22:46:06 Checking out Revision 19ce0a36c76c3d95658fecd8f59077fc9641e24c (master)
22:46:06  > git config core.sparsecheckout # timeout=10
22:46:06  > git checkout -f 19ce0a36c76c3d95658fecd8f59077fc9641e24c
22:46:06  > git rev-parse FETCH_HEAD^{commit} # timeout=10
22:46:06  > git rev-list 77201b6f671a163a60a2a4f4db89d7c9611950d3 # timeout=10
22:46:07  > git branch -a # timeout=10
22:46:07  > git rev-parse remotes/origin/0.2^{commit} # timeout=10
22:46:07  > git rev-parse remotes/origin/master^{commit} # timeout=10
22:46:07 Cloning the remote Git repository
22:46:07 Cloning repository git://gerrit.ovirt.org/jenkins.git
22:46:07  > git init
/home/jenkins/workspace/ovirt-imageio_master_check-patch-fc23-x86_64/jenkins
# timeout=10
22:46:07 Fetching upstream changes from git://gerrit.ovirt.org/jenkins.git
22:46:07  > git --version # timeout=10
22:46:07  > git fetch --tags --progress
git://gerrit.ovirt.org/jenkins.git +refs/heads/*:refs/remotes/origin/*
22:46:09  > git config remote.origin.url
git://gerrit.ovirt.org/jenkins.git # timeout=10
22:46:09  > git config --add remote.origin.fetch
+refs/heads/*:refs/remotes/origin/* # timeout=10
22:46:09  > git config remote.origin.url
git://gerrit.ovirt.org/jenkins.git # timeout=10
22:46:09 Cleaning workspace
22:46:09  > git rev-parse --verify HEAD # timeout=10
22:46:09 No valid HEAD. Skipping the resetting
22:46:09  > git clean -fdx # timeout=10
22:46:09 Pruning obsolete local branches
22:46:09 Fetching upstream changes from git://gerrit.ovirt.org/jenkins.git
22:46:09  > git fetch --tags --progress
git://gerrit.ovirt.org/jenkins.git +refs/heads/*:refs/remotes/origin/*
--prune
22:46:09  > git rev-parse origin/master^{commit} # timeout=10
22:46:09 Checking out Revision
25d8aa66b047b45ab52bc84ed7dfffedc5a3e222 (origin/master)
22:46:09  > git config core.sparsecheckout # timeout=10
22:46:09  > git checkout -f 25d8aa66b047b45ab52bc84ed7dfffedc5a3e222
22:46:09  > git rev-list 25d8aa66b047b45ab52bc84ed7dfffedc5a3e222 # timeout=10
22:46:09  > git branch -a # timeout=10
22:46:09  > git rev-parse remotes/origin/master^{commit} # timeout=10
22:46:09 [ovirt-imageio_master_check-patch-fc23-x86_64] $ /bin/bash -e
/tmp/hudson3544223073540002444.sh
22:46:09 shell-scripts/cleanup_slave.sh
22:46:09 ###################################################################
22:46:09 #    Cleaning up slave                                            #
22:46:09 ###################################################################
22:46:09 Filesystem      Size  Used Avail Use% Mounted on
22:46:09 /dev/vda3        30G  8.0G   21G  29% /
22:46:09 tmpfs           3.9G     0  3.9G   0% /dev/shm
22:46:09 /dev/vda1        93M   31M   58M  35% /boot
22:46:09 ---------------------------------------------------------------
22:46:09 Cleaning up postgres databases
22:46:09 /tmp ~/workspace/ovirt-imageio_master_check-patch-fc23-x86_64
22:46:09 ~/workspace/ovirt-imageio_master_check-patch-fc23-x86_64
22:46:09 done
22:46:09 Cleaning up journal logs (if any)
22:46:09   journald not running, skipping
22:46:09 Cleaning up /var/tmp
22:46:09 done
22:46:09 Emptying some common logs
22:46:09     /var/log/wtmp
22:46:09 Done
22:46:09     /home/jenkins/workspace/ovirt-engine_master_check-patch-el7-x86_64
22:46:10 Making sure there are no device mappings...
22:46:10 Removing the used loop devices...
22:46:10 losetup: invalid option -- 'D'
22:46:10
22:46:10 Usage:
22:46:10  losetup loop_device                             give info
22:46:10  losetup -a | --all                              list all used
22:46:10  losetup -d | --detach <loopdev> [<loopdev> ...] delete
22:46:10  losetup -f | --find                             find unused
22:46:10  losetup -c | --set-capacity <loopdev>           resize
22:46:10  losetup -j | --associated <file> [-o <num>]     list all
associated with <file>
22:46:10  losetup [ options ] {-f|--find|loopdev} <file>  setup
22:46:10
22:46:10 Options:
22:46:10  -e | --encryption <type> enable data encryption with
specified <name/num>
22:46:10  -h | --help              this help
22:46:10  -o | --offset <num>      start at offset <num> into file
22:46:10       --sizelimit <num>   loop limited to only <num> bytes of the file
22:46:10  -p | --pass-fd <num>     read passphrase from file descriptor <num>
22:46:10  -r | --read-only         setup read-only loop device
22:46:10       --show              print device name (with -f <file>)
22:46:10  -v | --verbose           verbose mode
22:46:10
22:46:10
22:46:10 Usage:
22:46:10  losetup loop_device                             give info
22:46:10  losetup -a | --all                              list all used
22:46:10  losetup -d | --detach <loopdev> [<loopdev> ...] delete
22:46:10  losetup -f | --find                             find unused
22:46:10  losetup -c | --set-capacity <loopdev>           resize
22:46:10  losetup -j | --associated <file> [-o <num>]     list all
associated with <file>
22:46:10  losetup [ options ] {-f|--find|loopdev} <file>  setup
22:46:10
22:46:10 Options:
22:46:10  -e | --encryption <type> enable data encryption with
specified <name/num>
22:46:10  -h | --help              this help
22:46:10  -o | --offset <num>      start at offset <num> into file
22:46:10       --sizelimit <num>   loop limited to only <num> bytes of the file
22:46:10  -p | --pass-fd <num>     read passphrase from file descriptor <num>
22:46:10  -r | --read-only         setup read-only loop device
22:46:10       --show              print device name (with -f <file>)
22:46:10  -v | --verbose           verbose mode
22:46:10