[ovirt-devel] [VDSM] build-artifacts failing on master

[Dan Kenigsberg]

On Thu, Sep 15, 2016 at 01:15:29PM +0300, Barak Korren wrote:
> >
> > I love running tests on the build systems - its gives another layer of
> > assurance that we are going to build a good package for the relevant
> > system/architecture.
> >
> > However, the offending patch makes it impossible on el7-based build
> > system. Can we instead skip the test (on such systems) if the right nose
> > version is not installed?
> >
> > We should file a bug to fix nose on el7.
> >
> 
> IMO test requirements != build req != runtime req.
> 
> It is perfectly valid to use virtualenv and pip to enable using the
> latest and graetest testing tools, but those should __only__ be used
> in a testing environment. Those should not be used in a build
> environment which is designed to be reproducible and hence is
> typically devoid of network access.

That's clear.

> Deploy requirements should be tested, but by their nature those tests
> need to run post-build and hence are better left to integration tests
> like ovirt-system-tests.

I'm not sure I understand your point. RPM spec files have %check section
for pre-build tests. Should we, or should we not, strive to use them?