[JIRA] (OVIRT-1154) Make jenkins-whitelist use Gerrit groups

[Barak Korren (oVirt JIRA)]

    [ https://ovirt-jira.atlassian.net/browse/OVIRT-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=27453#comment-27453 ] 

Barak Korren commented on OVIRT-1154:
-------------------------------------

Looks like scanning for commiters in Git can be pretty fast with something like:

{code}
git log --pretty=format:%ae 'HEAD@{360 days ago}..' | sort -u
{code}

Here is timing this for engine master on my laptop:

{code}
$ time git log --pretty=format:%ae 'HEAD@{360 days ago}..' | sort -u | wc -l
118

real	0m0.143s
user	0m0.124s
sys	0m0.043s
{code}

So we can probably do this per-job. But it may cause issues if we want to switch to sparse or shallow clones. In the case we will need some kind of a nightly job to scan all branches of all projects to find committers and then store them somewhere. That 'somewhere' should probably just be a Gerrit group (Can it be? Need to check how easy is it to map emails to Gerrit users in practice).

It may be more useful to somehow let maintainers (know contributors?) "confirm" a patch so that CI will check it, like we do for Lago.

> Make jenkins-whitelist use Gerrit groups
> ----------------------------------------
>
>                 Key: OVIRT-1154
>                 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1154
>             Project: oVirt - virtualization made easy
>          Issue Type: Improvement
>          Components: Jenkins
>            Reporter: Barak Korren
>            Assignee: infra
>
> Right now our white list is based on a text file with email addresses in it. Its kinda silly when we already have lists and groups of users in Gerrit.
> Some suggestions:
> * make any members of a project's "maintainers" group automatically white-listed
> * make a specific group for other white-listed people 



--
This message was sent by Atlassian JIRA
(v1000.769.1#100032)