[JIRA] (OVIRT-1064) Re-factor experimental groovy script

[Barak Korren (oVirt JIRA)]

     [ https://ovirt-jira.atlassian.net/browse/OVIRT-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Barak Korren updated OVIRT-1064:
--------------------------------
    Resolution: Won't Fix
        Status: Done  (was: To Do)

Closing this ticket because the 'experimental' flow will be deprecated by the 'change-queue' flow.

> Re-factor experimental groovy script
> ------------------------------------
>
>                 Key: OVIRT-1064
>                 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1064
>             Project: oVirt - virtualization made easy
>          Issue Type: Improvement
>          Components: oVirt CI
>            Reporter: Barak Korren
>            Assignee: infra
>
> The experimental Groovy scripts has several issues that should be resolved by re-factoring it:
> # Turn the variables defined in the top of the file into constants with upper case manes to ensure they're not used in functions by mistake
> # Remove unused arguments from functions
> # Move the main() function definition to the top of the file so its easier to quickly see an overview of the whole flow
> # Use the "global" constants inside main() instead of passing gazillion parameters to it.
> # Pass parameters directly to function instead of turning them into strings and using interpolation
> # Use 'for-each' loops instead of C-style indexed loops.
> # Use consistent indention throughout the file



--
This message was sent by Atlassian JIRA
(v1000.1092.1#100053)