[oVirt Jenkins] ovirt-system-tests_he-basic-suite-4.2 - Build # 69 - Failure!

[Yedidyah Bar David]

On Tue, Apr 3, 2018 at 8:54 PM,  <jenkins at jenkins.phx.ovirt.org> wrote:
> Project: http://jenkins.ovirt.org/job/ovirt-system-tests_he-basic-suite-4.2/
> Build: http://jenkins.ovirt.org/job/ovirt-system-tests_he-basic-suite-4.2/69/
> Build Number: 69
> Build Status:  Failure
> Triggered By: Started by timer
>
> -------------------------------------
> Changes Since Last Success:
> -------------------------------------
> Changes for Build #69
> [idodoroz] Fix snapshot_merge test
>
>
>
>
> -----------------
> Failed Tests:
> -----------------
> 1 tests failed.
> FAILED:  004_basic_sanity.snapshot_merge
>
> Error Message:
> list() got an unexpected keyword argument 'search'
> -------------------- >> begin captured logging << --------------------
> ovirtlago.testlib: ERROR:     * Unhandled exception in <function <lambda> at 0x7f317909ab90>
> Traceback (most recent call last):
>   File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line 219, in assert_equals_within
>     res = func()
>   File "/home/jenkins/workspace/ovirt-system-tests_he-basic-suite-4.2/ovirt-system-tests/he-basic-suite-4.2/test-scenarios/004_basic_sanity.py", line 180, in <lambda>
>     test_utils.all_jobs_finished(engine, correlation_id)
>   File "/home/jenkins/workspace/ovirt-system-tests_he-basic-suite-4.2/ovirt-system-tests/he-basic-suite-4.2/test-scenarios/test_utils/__init__.py", line 171, in all_jobs_finished
>     jobs = engine.jobs_service().list(search='correlation_id=%s' % correlation_id)
> TypeError: list() got an unexpected keyword argument 'search'
> --------------------- >> end captured logging << ---------------------
>
> Stack Trace:
>   File "/usr/lib64/python2.7/unittest/case.py", line 369, in run
>     testMethod()
>   File "/usr/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
>     self.test(*self.arg)
>   File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line 129, in wrapped_test
>     test()
>   File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line 59, in wrapper
>     return func(get_test_prefix(), *args, **kwargs)
>   File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line 78, in wrapper
>     prefix.virt_env.engine_vm().get_api(api_ver=4), *args, **kwargs
>   File "/home/jenkins/workspace/ovirt-system-tests_he-basic-suite-4.2/ovirt-system-tests/he-basic-suite-4.2/test-scenarios/004_basic_sanity.py", line 179, in snapshot_merge
>     lambda:
>   File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line 267, in assert_true_within_short
>     assert_equals_within_short(func, True, allowed_exceptions)
>   File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line 251, in assert_equals_within_short
>     func, value, SHORT_TIMEOUT, allowed_exceptions=allowed_exceptions
>   File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line 219, in assert_equals_within
>     res = func()
>   File "/home/jenkins/workspace/ovirt-system-tests_he-basic-suite-4.2/ovirt-system-tests/he-basic-suite-4.2/test-scenarios/004_basic_sanity.py", line 180, in <lambda>
>     test_utils.all_jobs_finished(engine, correlation_id)
>   File "/home/jenkins/workspace/ovirt-system-tests_he-basic-suite-4.2/ovirt-system-tests/he-basic-suite-4.2/test-scenarios/test_utils/__init__.py", line 171, in all_jobs_finished
>     jobs = engine.jobs_service().list(search='correlation_id=%s' % correlation_id)
> 'list() got an unexpected keyword argument \'search\'\n-------------------- >> begin captured logging << --------------------\novirtlago.testlib: ERROR:     * Unhandled exception in <function <lambda> at 0x7f317909ab90>\nTraceback (most recent call last):\n  File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line 219, in assert_equals_within\n    res = func()\n  File "/home/jenkins/workspace/ovirt-system-tests_he-basic-suite-4.2/ovirt-system-tests/he-basic-suite-4.2/test-scenarios/004_basic_sanity.py", line 180, in <lambda>\n    test_utils.all_jobs_finished(engine, correlation_id)\n  File "/home/jenkins/workspace/ovirt-system-tests_he-basic-suite-4.2/ovirt-system-tests/he-basic-suite-4.2/test-scenarios/test_utils/__init__.py", line 171, in all_jobs_finished\n    jobs = engine.jobs_service().list(search=\'correlation_id=%s\' % correlation_id)\nTypeError: list() got an unexpected keyword argument \'search\'\n--------------------- >> end captured logging << ---------------------'

Ido, your fix works for master/4.3, but not for 4.2 - see also e.g.:

http://lists.ovirt.org/pipermail/devel/2018-March/032712.html
https://gerrit.ovirt.org/#/c/88441/

Can you please back-port to 4.2? Thanks.

Also, not sure how it passed CI on 4.2 - I guess it installed sdk4
from master repo, and that above failure didn't. Do not fully understand
how this works, though.

Best regards,
-- 
Didi