[JIRA] (OVIRT-1895) CI votes not forwarded on commit message change

[Daniel Belenky (oVirt JIRA)]

    [ https://ovirt-jira.atlassian.net/browse/OVIRT-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=35821#comment-35821 ] 

Daniel Belenky commented on OVIRT-1895:
---------------------------------------

It's a known bug that's coming from the Gerrit Trigger Plugin,  the current solution is not to push commit message changes if you have CI tests running.

> CI votes not forwarded on commit message change
> -----------------------------------------------
>
>                 Key: OVIRT-1895
>                 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1895
>             Project: oVirt - virtualization made easy
>          Issue Type: By-EMAIL
>            Reporter: Yedidyah Bar David
>            Assignee: infra
>
> Hi all,
> If a change goes through this flow:
> 1. Push an update N
> 2. CI triggers check-patch for N
> 3. Push another update N+1 that changes only commit message
> 4. CI marks +1 N
> Then we have logic to not trigger CI for N+1 (with the assumption that
> a change to commit message should not affect the result), but also do
> not mark +1 N+1, leaving the patch unmarked.
> We should either forward the +1, when giving it, to all consecutive
> future patchsets that only changed the commit message, or give up on
> the optimization and always trigger CI.
> As an example, see:
> https://gerrit.ovirt.org/87515
> Best regards,
> -- 
> Didi



--
This message was sent by Atlassian Jira
(v1001.0.0-SNAPSHOT#100079)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/infra/attachments/20180213/cc0a2ba7/attachment-0001.html>