[Kimchi-devel] [PATCH V3 0/3] bug fix: get user and group when VM is running

[Aline Manera]

On 04/22/2014 01:59 PM, Aline Manera wrote:
> On 04/22/2014 12:59 AM, shaohef at linux.vnet.ibm.com wrote:
>> From: ShaoHe Feng<shaohef at linux.vnet.ibm.com>
>>
>> V2 -> V3:
>> move the virDomain.metadata and virDomain.setMetadata to model/utils.py
>> add testcase
>>
>> V1 -> V2:
>> libvirt also support virDomain.metadata and virDomain.setMetadata two api.
>> use virDomain.metadata to get the user and group.
>> use virDomain.setMetadata to set the user and group.
>>
>> ShaoHe Feng (3):
>>    Add two function to set and get domain xml metadata
>>    bug fix: get user and group when vm is living.
>>    update test case to set/get user and group when VM is running
>>
>>   src/kimchi/i18n.py        |  1 +
>>   src/kimchi/model/utils.py | 41 ++++++++++++++++++++++++++++++
>>   src/kimchi/model/vms.py   | 65 +++++++++++++++++++++++------------------------
>>   tests/test_model.py       | 13 ++++++++++
>>   4 files changed, 87 insertions(+), 33 deletions(-)
>>
> As I commented in previous version, virDomain.metadata and 
> virDomain.setMetadata does not work
> well in all libvirt versions
>
> ----------------------------------------
>
> During the first development, I noticed the virDomain.metadata and 
> virDomain.setMetadata does not work
> well in all libvirt versions.
>
> While using those functions, some libvirt versions will report:
>
> libvir: QEMU Driver error : argument unsupported: QEMU driver does not 
> support<metadata> element
>
> But if you manually get and set metadata element, libvirt works fine.
>
>

I agree with the other changes you proposed in this patch but you need 
to keep manually manage the metadata element
until we get virDomain.metadata and virDomain.setMetadata working in all 
livirt versions used in the supported distros.

> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20140422/38706fcb/attachment.html>