[Kimchi-devel] [PATCH] UI: refactor guest edit code.

[simonjin]

On 08/12/2014 02:41 AM, Crístian Viana wrote:
> On 11-08-2014 11:22, shaohef at linux.vnet.ibm.com wrote:
>> From: ShaoHe Feng<shaohef at linux.vnet.ibm.com>
>>
>> We don not need a special "save" button for permission form.
>>
>> All form in guest edit tab can share the same "save" button.
>>
>> also, we will add a password form, it will also share this button.
>>
>> Signed-off-by: ShaoHe Feng<shaohef at linux.vnet.ibm.com>
>> Signed-off-by: Simon Jin<simonjin at linux.vnet.ibm.com>
>>
> Why are we using a save button for each tab in that dialog? That's 
> definitely not a common user experience. One would expect that a 
> "Save" button in that dialog would apply all changes done in the 
> dialog, not on that tab alone. What if the user wants to change the VM 
> name and permission (and the password, after the next patch)? They 
> will need to open the "Edit Guest" dialog, changing the value they 
> want to change, and then saving that value alone. /Three times./ 
> That's not a good flow.
>
> IMO, we should have only one "Save" button which, when clicked, 
> applies all the changes done in that dialog. Not a button which does 
> different things depending on which tab the user is on.
That's not always true, at least on virt-manager.
one thing can be improved here is to disable the "save" button when 
there isn't having any change on the tab yet and enable it when there is.

-Simon
>
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel


-- 
Yun Tong Jin, Simon
Linux Technology Center, Open Virtualization project
IBM Systems&  Technology Group
jinyt at cn.ibm.com, Phone: 824549654

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20140812/8ec1ce5d/attachment.html>