[Kimchi-devel] [PATCH] Python: Do not allow lines longer than 80 characters

[Aline Manera]

On 01/23/2014 12:01 AM, Mark Wu wrote:
> On 01/22/2014 08:54 PM, Crístian Viana wrote:
>> Hi Mark, thanks for the feedback!
>>
>> I haven't read the PEP8 correctly, I thought the length limit was 80 
>> characters, but I see it's 79 indeed.
>>
>> I decided to validate only this PEP8 feature for now (maximum line 
>> length) for all files instead of completely cleaning file by file. At 
>> least now there'll be one less rule left :-)
>>
>> I'll send a new patch fixing the new line length value.
> Personally,  I don't like the fix special for the line length.  I 
> prefer to include it in a pep8 clean for a file.
> The reason is that:  even if fix the line length, we don't have a tool 
> to check new changed code does't
> have this problem.  But for pep8, there's no this kind of problem.  
> After we clean up one file,  we can
> add it to the WHITELIST,  and the developer can check if it cause new 
> style problem by running 'make check-local'
>

I agree with Mark.
Even if we correct the line length now there is no way to guarantee new 
code will respect that in future.

>
>
>
>>
>> Am 21-01-2014 23:41, schrieb Mark Wu:
>>> Hi Crístian,
>>>
>>> I like the idea of cleanup,  but for python projects,  we should 
>>> comply with PEP8[1], which limit all lines to a maximum of 79 
>>> characters.   So after we can all files pep clean,  it will resolve 
>>> the line length problem too.
>>>
>>> If you have interest in the pep8 clean,  you could use the command 
>>> line tool pep8 and or vim plugin[2] to check if a python file is 
>>> pep8 clean.  After the cleanup,  we need put it to the list of 
>>> PEP8_WHITELIST in Makefile.am.  It can guarantee the files are 
>>> checked when 'make check-local'  is executed.
>>>
>>> [1] http://www.python.org/dev/peps/pep-0008/#maximum-line-length
>>> [2] 
>>> https://github.com/kimchi-project/kimchi/wiki/PEP8-Checking-Using-Syntastic
>
>
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20140125/ab4ed264/attachment.html>