[Kimchi-devel] [V2 0/2] Authorization: Add users/groups to VM

[Aline Manera]

On 07/24/2014 06:06 AM, Yu Xin Huo wrote:
> On 7/22/2014 10:13 PM, Aline Manera wrote:
>>
>> Looks good for me.
>>
>> But we need to allow change the VM permissions when it is running
>> I've just tested it and it works fine using the REST API.
>>
>> My suggestion is replace the "Manage Media" menu option to "Edit" 
>> when VM is running.
>> And add the same tab layout there. One tab for "Storage" - to manage 
>> media, and other one for "Permission"
>> Also it would be good to have the same layout on "Storage" tab we 
>> have when the VM is stopped.
>> Let me know how much is needed to have it done so we can split it 
>> into smaller tasks or drop this to sprint 2.
> Aline, If I understand correctly, you mean below:
> 1. add a new tab(manage media) in vm edit to remove the 'manage media' 
> menu item in Actions dropdown.
> 2. the 'manage media' only available when vm is started.
> 3. for the content of 'manage media', it should take the same layout 
> as storage tab.

Partial correctly. :-)

I want to also have a "Edit" action when the VM is running.
This "Edit" would open a dialog (like it is when the VM is stopped) but 
display only 2 tabs: "Manage Media" and "Permission"

So the edit dialog should be build dynamically according to VM state:

- state == running: display "Manage Media" and "Permission" tabs
- state == stopped: display all tabs we do today

Does that make more sense now?


>>
>> And if you don't mind, I have one more suggestion to make.
>> Add the same column headers to the selected users/groups box.
> Addressed in V3.
>>
>>
>>
>>
>>
>>
>> On 07/22/2014 06:33 AM, huoyuxin at linux.vnet.ibm.com wrote:
>>> From: Yu Xin Huo<huoyuxin at linux.vnet.ibm.com>
>>>
>>> Yu Xin Huo (2):
>>>    Add users/groups to VM
>>>    po files update for permission
>>>
>>>   po/en_US.po                         |    9 +++
>>>   po/kimchi.pot                       |    9 +++
>>>   po/pt_BR.po                         |    9 +++
>>>   po/zh_CN.po                         |    9 +++
>>>   ui/css/theme-default/guest-edit.css |  116 +++++++++++++++++++++++++++++++++++
>>>   ui/images/theme-default/group.png   |  Bin 0 -> 1703 bytes
>>>   ui/images/theme-default/user.png    |  Bin 0 -> 1322 bytes
>>>   ui/js/src/kimchi.api.js             |   28 ++++++++
>>>   ui/js/src/kimchi.guest_edit_main.js |  112 ++++++++++++++++++++++++++++++++-
>>>   ui/pages/guest-edit.html.tmpl       |   37 +++++++++++
>>>   10 files changed, 326 insertions(+), 3 deletions(-)
>>>   create mode 100644 ui/images/theme-default/group.png
>>>   create mode 100644 ui/images/theme-default/user.png
>>>
>>> _______________________________________________
>>> Kimchi-devel mailing list
>>> Kimchi-devel at ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20140724/1efc7815/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/jpeg
Size: 10430 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20140724/1efc7815/attachment.jpe>