[Kimchi-devel] [PATCH 0/3] [new-ui] Guests tab and Admin SCSS

Thu Nov 26 12:23:54 UTC 2015

On 26/11/2015 10:18, Samuel Guimarães wrote:
>
>
> 2015-11-25 22:08 GMT-02:00 Aline Manera <alinefm at linux.vnet.ibm.com 
> <mailto:alinefm at linux.vnet.ibm.com>>:
>
>
>
>     On 25/11/2015 22:06, Aline Manera wrote:
>>
>>     The filter in the guest tab is not working too.
>>
>
>     The filter is not working in the Templates tab too.
>
>
> The filters are not working because they are just placeholders. We can 
> hide them for now and implement the filter function as bugfix or in 
> the next release because unlike Storages and Networks that uses a 
> jQuery-UI widget for table creation (that has access to all jQuery UI 
> methos), Templates and Guests are plain HTML lists manipulated by 
> JavaScript. I believe it is not difficult to do that in Templates but 
> as for Guests it implies that we should stop the VM stats refresh then 
> filter and later on new stat refresh we would have to keep track of 
> the list position. Right now on each stat refresh the whole list is 
> rebuilt in the DOM. We also have to add the sortable filter in the 
> gallery view:

OK. Let treat the filter as an issue and fix it after getting the new UI 
upstream.

>
>
> I think for the sortable we don't need to adjust anything in the 
> backend, jQuery-UI can reorder the ajax response but that means we 
> would have to rewrite the Guests Lists into a Sortable widget 
> (https://jqueryui.com/sortable/). It is not difficult but consumes a 
> lot of time.
>
>
>
>>     On 25/11/2015 22:03, Aline Manera wrote:
>>>
>>>     Hi Samuel,
>>>
>>>     Seems the columns are not aligned with the headers:
>>>
>>>
>>>
>>>     Please, replace "Virtual Network Console" to "Console".
>>>
>>>     Also the statistic related to memory is about memory utilization
>>>     instead of memory available. So change "Memory Available" to
>>>     "Memory utilization" or "Memory used"
>>>
>>>     It would be good to allow user select the "power on/off" icon to
>>>     start/stop the guest too. But we can do that after getting the
>>>     new UI upstream.
>>>
>>>     Regards,
>>>     Aline Manera
>
>
> This is the desgin spec:
>
>
> And this is the current version:
>
>
> 
> In this version we don't support sorting, so that's why we don't have 
> the arrow-up and arrow-down icons on the table headers. Here the 
> horizontal alignment is ok. The vertical alignment is weird but we 
> followed the mock-ups. I'll change Virtual Network Console to VNC and 
> the Memory Available to Memory Utilization.
>

Thanks!

> Regarding the icons, I agree this can be done after this page is 
> upstream because this wasn't listed as requirement in the design specs.

Yeap! It is a suggestion! We don't need to have it now.

>
>>>
>>>     On 25/11/2015 19:25, sguimaraes943 at gmail.com
>>>     <mailto:sguimaraes943 at gmail.com> wrote:
>>>>     From: samhenri<samuel.guimaraes at eldorado.org.br>
>>>>     <mailto:samuel.guimaraes at eldorado.org.br>
>>>>
>>>>     This patch adds new-ui to Guests page and some styles for new-ui in Ginger.
>>>>
>>>>     Andre Teodoro (1):
>>>>        [new-ui] Adding new-ui to Administration tab
>>>>     	* If applied may break some jQuery-UI collapsible elements
>>>>
>>>>     samhenri (2):
>>>>        Minor CSS fixes in the new-ui
>>>>        [new-ui] Guests tab
>>>>
>>>>       .../plugins/kimchi/ui/css/theme-default/list.css   | 330 ----------
>>>>       .../plugins/kimchi/ui/js/src/kimchi.guest_main.js  | 676 +++++++++++++--------
>>>>       src/wok/plugins/kimchi/ui/pages/guest.html.tmpl    | 125 ++--
>>>>       src/wok/plugins/kimchi/ui/pages/guests.html.tmpl   |  33 +-
>>>>       ui/css/src/modules/_administration.scss            | 340 +++++++++++
>>>>       ui/css/src/modules/_guests.scss                    | 241 ++++++++
>>>>       ui/css/src/modules/_network.scss                   |   2 +-
>>>>       ui/css/src/modules/_storage.scss                   |   2 +-
>>>>       ui/css/src/modules/_wok-grid.scss                  |   2 +-
>>>>       ui/css/src/modules/_wok-variables.scss             |   9 +-
>>>>       ui/images/theme-default/icon-unknown.png           | Bin 761 -> 3797 bytes
>>>>       11 files changed, 1115 insertions(+), 645 deletions(-)
>>>>       delete mode 100644 src/wok/plugins/kimchi/ui/css/theme-default/list.css
>>>>
>>>
>>>
>>>
>>>     _______________________________________________
>>>     Kimchi-devel mailing list
>>>     Kimchi-devel at ovirt.org <mailto:Kimchi-devel at ovirt.org>
>>>     http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>>
>>
>>
>>     _______________________________________________
>>     Kimchi-devel mailing list
>>     Kimchi-devel at ovirt.org <mailto:Kimchi-devel at ovirt.org>
>>     http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20151126/086ef905/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/jpeg
Size: 21313 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20151126/086ef905/attachment.jpe>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/jpeg
Size: 21131 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20151126/086ef905/attachment-0001.jpe>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/jpeg
Size: 40898 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20151126/086ef905/attachment-0002.jpe>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/jpeg
Size: 41738 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20151126/086ef905/attachment-0003.jpe>