[node-patches] Change in ovirt-node[master]: add in missing appvg creation from bash storage scripts

[mburns at redhat.com]

Michael Burns has posted comments on this change.

Change subject: add in missing appvg creation from bash storage scripts
......................................................................


Patch Set 2: Fails; I would prefer that you didn't submit this

(2 inline comments)

....................................................
File scripts/storage.py
Line 424:         logger.debug("DATA2_SIZE: " + self.DATA2_SIZE)
this fails with a "string and list can't be concatenated" error

-        logger.debug("APPVGDRIVE: " + self.APPVGDRIVE)
-        logger.debug("SWAP2_SIZE: " + self.SWAP2_SIZE)
-        logger.debug("DATA2_SIZE: " + self.DATA2_SIZE)
+        logger.debug("APPVGDRIVE: " + ' '.join(self.APPVGDRIVE))
+        logger.debug("SWAP2_SIZE: " + ' '.join(self.SWAP2_SIZE))
+        logger.debug("DATA2_SIZE: " + ' '.join(self.DATA2_SIZE))

Line 479:             use_data = 0
Something is broken here.  It seems that it's not comparing -1 and self.DATA2_SIZE as an integer.  When I ran through this I got the swap partition fine, but no DATA2 partition.

--
To view, visit http://gerrit.ovirt.org/170
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d7c97b00ea10382bca1894e172958447a9b1aee
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>