[node-patches] Change in ovirt-node[master]: add in missing appvg creation from bash storage scripts

[mburns at redhat.com]

Michael Burns has posted comments on this change.

Change subject: add in missing appvg creation from bash storage scripts
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File scripts/storage.py
Line 424:         logger.debug("DATA2_SIZE: " + ''.join(str(self.DATA2_SIZE)))
OK, my previous comment wasn't thought out completely

APPVGDRIVE is aray, so needs to be set to:
logger.debug("APPVGDRIVE: " + ' '.join(self.APPVGDRIVE))

Shouldn't need to cast it to a string

SWAP2_SIZE and DATA2_SIZE should be integers, so just cast to string rather than the join

logger.debug("SWAP2_SIZE: " + str(self.SWAP2_SIZE))
logger.debug("SWAP2_SIZE: " + str(self.DATA2_SIZE))

--
To view, visit http://gerrit.ovirt.org/170
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d7c97b00ea10382bca1894e172958447a9b1aee
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>